Re: [PATCH] usb: gadget: mv_u3d_core: fix memory leaks

[Valentin Ilie]

On 21 September 2013 12:30, Valentin Ilie <valentin.ilie@xxxxxxxxx> wrote:
> When trb_hw is NULL, trb should be free'd before return.
>
> Signed-off-by: Valentin Ilie <valentin.ilie@xxxxxxxxx>
> ---
>  drivers/usb/gadget/mv_u3d_core.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c
> index 561b30e..4d31177 100644
> --- a/drivers/usb/gadget/mv_u3d_core.c
> +++ b/drivers/usb/gadget/mv_u3d_core.c
> @@ -310,6 +310,7 @@ static struct mv_u3d_trb *mv_u3d_build_trb_one(struct mv_u3d_req *req,
>          */
>         trb_hw = dma_pool_alloc(u3d->trb_pool, GFP_ATOMIC, dma);
>         if (!trb_hw) {
> +               kfree(trb);
>                 dev_err(u3d->dev,
>                         "%s, dma_pool_alloc fail\n", __func__);
>                 return NULL;
> @@ -454,6 +455,7 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req)
>
>                 trb_hw = kcalloc(trb_num, sizeof(*trb_hw), GFP_ATOMIC);
>                 if (!trb_hw) {
> +                       kfree(trb);
>                         dev_err(u3d->dev,
>                                         "%s, trb_hw alloc fail\n", __func__);
>                         return -ENOMEM;
> --
> 1.7.9.5
>

Can anyone look into this?

Thank you

-- 
Valentin Ilie
+(40) 746 188 558
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/