Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA enginedevice tree nodes

From: Scott Wood
Date: Wed Sep 25 2013 - 21:47:43 EST


On Wed, 2013-09-25 at 15:35 +0800, Hongbo Zhang wrote:
> By the way, I know maybe it is difficult, but why not introduce a
> document of maintaining rules for the dt binding docs? we have dedicated
> maintainers for this part now. Description language from one submitter
> cannot satisfy every reviewer/maintainer, for a reg property, is it
> necessary to say "offset and length",

Don't say "offset and length". It's both redundant with the base
definition of the reg property, and overly specific because it makes
assumptions about how the parent node's ranges are set up (sometimes we
want to be that specific, but usually not).

> to say "how many entries", to say "register functions and even names"?

If there's more than one
entry/resource/whatever-we-decide-to-call-it-but-let's-pick-something-canonical, then say how many there are and what each one means.

-Scott



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/