Re: [PATCH] checkpatch: Find CamelCase definitions ofstruct/union/enum

[Al Viro]

On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote:

> We disagree.

Obviously.

> I think Propercase should be discouraged.
> ie: Qdisc et al.

Excuse me, but "Joe happens to think that something should be discouraged"
is not a problem.  "Joe uses checkpatch.pl as force multiplier, recruiting
hundreds of monkeys to enforce his personal preferences", OTOH, very much is.

You are calling for ban on any mixed-case identifiers.  I see at least three
cases where they can be legitimate:
	* labels a-la Enomem, etc.  I've been using those and I will
keep doing so, checkpatch.pl and its users be damned.
	* enum members, to distinguish those from defines (first letter
capitalized vs. all-caps).
	* (local) typedefs for structs; I really don't like their use for
anything non-local, but IMO they have their uses in cases like e.g.
fs/binfmt_misc.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/