Re: [PATCH 02/20] regulator: ab8500: use devm_regulator_register()

From: Sachin Kamat
Date: Wed Sep 25 2013 - 06:20:37 EST


On 25 September 2013 13:21, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> Use devm_regulator_register() to make cleanup paths simpler.

> - for (i = 0; i < abx500_regulator.info_size; i++) {
> - struct ab8500_regulator_info *info = NULL;
> - info = &abx500_regulator.info[i];
> -
> - dev_vdbg(rdev_get_dev(info->regulator),
> - "%s-remove\n", info->desc.name);
> -
> - regulator_unregister(info->regulator);
> - }
> + int err;
>
> /* remove regulator debug */
> err = ab8500_regulator_debug_exit(pdev);

Wouldn't re-ordering (unregistering after ab8500_regulator_debug_exit)
cause any problems here ?

--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/