Re: [PATCH 5/6] USB: gadget: s3c-hsotg: fix dedicated fifos handling

From: Felipe Balbi
Date: Tue Sep 17 2013 - 11:59:46 EST


On Thu, Sep 12, 2013 at 04:18:51PM +0200, Robert Baldyga wrote:
> This patch adds few fixes:
> - In s3c_hsotg_write_fifo function PTxFEmp/NPTxFEmp interrupts are enabled
> only in shared-fifo mode. In dedicated-fifo mode they should not be used
> (when enabled then cause interrupt storm).
> - When s3c_hsotg_trytx is called for ep without enqueued request, interrupts
> for this ep are disabled, to prevent interrupt flooding. Interrupts are
> enabled when new request for this ep is starting.
> - In s3c_hsotg_core_init enabled INTknTXFEmpMsk, becouse without this mask
> TxFIFOEmpty interrupt does not occur.
> - In OEPInt/IEPInt interrupts handling added bitwise and of DAINT and
> DAINTMSK, because we should handle masked interrupts only.

each fix in its own patch please.

--
balbi

Attachment: signature.asc
Description: Digital signature