Re: scripts/config: fix variable substitution command
From: Sedat Dilek
Date: Sat Sep 14 2013 - 08:21:55 EST
Hi,
The ChangeLog from [1] says:
Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
the separator between sed `s' command and its parameters from ':' to
'/'.
Revert this change.
Reported-and-tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Clement Chauplannaz <chauplac@xxxxxxxxx>
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
*** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 ***
(Linus-tree)
To quote [2] and see its EXAMPLE:
"If you want to refer to a specific commit, don't just refer to the
SHA-1 ID of the commit. Please also include the oneline summary of
the commit, to make it easier for reviewers to know what it is about.
Example:
Commit e21d2170f36602ae2708 ("video: remove unnecessary
platform_set_drvdata()") removed the unnecessary
platform_set_drvdata(), but left the variable "dev" unused,
delete it."
That's why the commit-id without the subject-line is no good help.
It does not help anyone when you reference a local GIT or linux-kbuild
GIT related commit-id.
So, can you point me/us to the correct commit with subject, please?!
Is this patch even "CC: stable"?
Thanks.
Regards,
- Sedat -
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d
[2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/