Re: [PATCH] firmware: Be a bit more verbose about direct firmwareloading failure

From: Ming Lei
Date: Thu Sep 12 2013 - 10:31:09 EST


On Thu, Sep 12, 2013 at 9:16 PM, Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:
>>
> Please re-read the patch, then point out to me which printk the above action
> will trigger, because its not happening in my testing. If you'll take a look at
> fw_get_filesystem_firmware, you'll see that if the filp_open on a firmware file
> fails, we continue the for loop through the list of available search paths. No
> error is generated in the case you describe above.

You are right, sorry for missing "if (IS_ERR(file)) continue;", and looks the
patch is good.

Acked-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/