Re: [PATCH] /dev/random: Insufficient of entropy on many architectures

[Stephan Mueller]

Am Donnerstag, 12. September 2013, 13:59:04 schrieb Geert Uytterhoeven:

Hi Geert,

>On Wed, Sep 11, 2013 at 8:49 AM, Stephan Mueller <smueller@xxxxxxxxxx> 
wrote:
>> __u64 tmp = random_get_fast_cycles() - random_get_fast_cycles();
>> if(0 == tmp)
>> 
>>         return fail;
>> 
>> return pass;
>
>That will fail if the cycle counter runs at less than say 4 times the
>CPU clock...

Well...
>
>BTW, I prefer a different name than "random_get_fast_cycles()", as it's
>better to have something that returns different and unpredictable
>numbers than an actual monotonic cycle counter.

A monotonic counter is fully ok. Note, for /dev/random, the occurrence 
of events delivers entropy. Thus, we have to be able to precisely 
measure that occurrence. The timer itself does not need to deliver any 
entropy as long as it is fast.
>
>Gr{oetje,eeting}s,
>
>                        Geert
>
>--
>Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
>geert@xxxxxxxxxxxxxx
>
>In personal conversations with technical people, I call myself a
>hacker. But when I'm talking to journalists I just say "programmer" or
>something like that. -- Linus Torvalds


Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/