Re: [PATCH 1/3] ARM: OMAP2+: hwmod-data: Add SSI information

[Sebastian Reichel]

Hi Paul,

On Wed, Aug 21, 2013 at 01:22:09AM +0000, Paul Walmsley wrote:
> > From: Sebastian Reichel <sre@xxxxxxxx>
> > This patch adds Synchronous Serial Interface (SSI) hwmod support for
> > OMAP34xx SoCs.
> 
> a few comments:
> 
> - please add your Signed-off-by: to the patch description, per 
> Documentation/SubmittingPatches

I assumed this was only important, when I actually want to submit
patches.  This was merely a first RFC. I will do this for the next
round of patches.

> - please drop "omap34xx_ssi_irqs" and "omap34xx_ssi_addrs" - that data 
> should go into DT now

I'm currently working on converting the driver to use DT.
I will send another patch when I'm done.

> [...]
> FYI, this is stretching my recollection, and is not directly related to 
> this patch, but I seem to recall that there was a problem with auto-idle 
> when SSI was active on the 3430.  Basically, if the SSI was active, but 
> other CORE_L3/CORE_L4 clockdomain devices weren't, I think that DPLL3 
> would be incorrectly shut down.  You'll probably need to check the Nokia 
> kernel source for details.  I thought we had a hwmod flag for this, but I 
> guess not.  Anyway, in case you notice odd behavior...

OK. Thanks for the hint.

-- Sebastian

Attachment: signature.asc
Description: Digital signature