Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap

[Linus Walleij]

On Thu, Aug 22, 2013 at 3:22 PM, Ezequiel Garcia
<ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote:
>> Add missing iounmap to prove error path and remove path
>>
>> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
>> ---
>>  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++-------
>>  1 file changed, 17 insertions(+), 7 deletions(-)
>
> How about using devm_ioremap_resource() instead?

Yeah that's the right solution, Jisheng can you fix this?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/