Re: [PATCH] dma: ste_dma: Fix warning when CONFIG_ARM_LPAE=y

From: Linus Walleij
Date: Fri Aug 23 2013 - 14:03:15 EST


On Thu, Aug 22, 2013 at 2:34 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:

> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> When CONFIG_ARM_LPAE=y the following build warning are generated:
>
> drivers/dma/ste_dma40.c:3228:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
> drivers/dma/ste_dma40.c:3582:3: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
> drivers/dma/ste_dma40.c:3582:3: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t' [-Wformat]
> drivers/dma/ste_dma40.c:3593:5: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t' [-Wformat]
>
> According to Documentation/printk-formats.txt '%pa' can be used to properly
> print 'resource_size_t'.
>
> Also, for printing memory region the '%pr' is more convenient.
>
> Reported-by: Kevin Hilman <khilman@xxxxxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

Elegant!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Vinod, can you apply this?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/