Re: [PATCH -next] staging: lustre: Use proper constant types forL*_POISON values

From: Greg Kroah-Hartman
Date: Fri Aug 23 2013 - 13:21:09 EST


On Fri, Aug 23, 2013 at 05:46:48PM +0200, Geert Uytterhoeven wrote:
> On 32-bit m68k, I get lots of warnings like:
>
> warning: integer constant is too large for âlongâ type
>
> Switch the L*_POISON definitions from too-large constants and casts
> to the proper constant types to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> The values in drivers/staging/lustre/lustre/include/linux/lustre_lib.h
> don't seem to be used, as LP_POISON is already defined at that point?

Probably. I don't see where anyone even uses these "poison" values,
except to check variables to ensure they don't contain the value, which
is always going to be true as no one sets them.

Oh well, more dead code in the driver, nothing new...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/