Re: [PATCH v3 2/2] max77693: added device tree support

[Mark Rutland]

On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote:
> This patch adds only of_match_table.
> There are no device specific properties.

Could you clarify what functionality this enables and what it doesn't,
please?

This doesn't seem to enable support for the regulators described in the
binding [1] (which from the looks of it needs proof-reading and possibly
rework).

Are there any changes we might need in future to either support new
functionality or to generalise the binding. e.g. do we need a regulator
for the LED? 

Given the binding has never been supported, are we happy now that it
best represents the hardware, or are there avenues of improvement
*before* it becomes ABI?

Thanks,
Mark.

[1] Documentation/devicetree/bindings/mfd/max77693.txt

> 
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/mfd/max77693.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 27f5da3..e0b11a9 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -225,11 +225,19 @@ static const struct dev_pm_ops max77693_pm = {
>  	.resume = max77693_resume,
>  };
>  
> +#ifdef CONFIG_OF
> +static struct of_device_id max77693_dt_match[] = {
> +	{.compatible = "maxim,max77693"},
> +	{},
> +};
> +#endif
> +
>  static struct i2c_driver max77693_i2c_driver = {
>  	.driver = {
>  		   .name = "max77693",
>  		   .owner = THIS_MODULE,
>  		   .pm = &max77693_pm,
> +		   .of_match_table = of_match_ptr(max77693_dt_match),
>  	},
>  	.probe = max77693_i2c_probe,
>  	.remove = max77693_i2c_remove,
> -- 
> 1.8.1.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/