RE: [RFC PATCH v2 04/11] pstore: Add compression support to pstore
From: Seiji Aguchi
Date: Thu Aug 22 2013 - 19:47:33 EST
> -----Original Message-----
> From: Luck, Tony [mailto:tony.luck@xxxxxxxxx]
> Sent: Thursday, August 22, 2013 7:17 PM
> To: Seiji Aguchi; Aruna Balakrishnaiah; linuxppc-dev@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; keescook@xxxxxxxxxxxx
> Cc: jkenisto@xxxxxxxxxxxxxxxxxx; ananth@xxxxxxxxxx; benh@xxxxxxxxxxxxxxxxxxx; cbouatmailru@xxxxxxxxx;
> mahesh@xxxxxxxxxxxxxxxxxx; ccross@xxxxxxxxxxx
> Subject: RE: [RFC PATCH v2 04/11] pstore: Add compression support to pstore
>
> <1>[ 383.209057] RIP [<ffffffff813d3946>] sysrq_handle_crash+0x16/0x20
> <4>[ 383.209057] RSP <ffff88006f551e80>
> <4>[ 383.209057] CR2: 0000000000000000
> <4>[ 383.209057] ---[ end trace 04a1cddad37b4b33 ]---
> <3>[ 383.209057] pstore: compression failed for Part 2 returned -5
> <3>[ 383.209057] pstore: Capture uncompressed oops/panic report of Part 2
> <3>[ 383.209057] pstore: compression failed for Part 5 returned -5
>
> Interesting. With ERST backend I didn't see these messages. Traces in
> pstore recovered files go as far as the line before the "---[ end trace 04a1cddad37b4b33 ]---"
>
> Why the difference depending on which back end is in use?
I think the difference doesn't depend on the back end.
Rather it depends on the environment.
I tested on a kvm guest with OVMF.
Seiji
>
> But I agree that we shouldn't have these messages. They use up space
> in the persistent store that could be better used saving some more lines
> from earlier in the console log.
>
> -Tony
¢éì®&Þ~º&¶¬+-±éÝ¥w®Ë±Êâmébìdz¹Þ)í
æèw*jg¬±¨¶Ýj/êäz¹Þà2Þ¨èÚ&¢)ß«a¶Úþø®G«éh®æj:+v¨wèÙ>W±êÞiÛaxPjØm¶ÿÃ-»+ùd_