Re: [PATCH v2] vfs: Tighten up linkat(..., AT_EMPTY_PATH)

From: Willy Tarreau
Date: Thu Aug 22 2013 - 16:15:45 EST


On Thu, Aug 22, 2013 at 01:10:43PM -0700, Andy Lutomirski wrote:
> What's the point of nd_jump_link anyway? The only way I can think of
> for a magic symlink in /proc to point to another symlink is to open a
> symlink with O_PATH | O_NOFOLLOW. Actually trying to use the
> resulting link in /proc results in -ELOOP. (Even just trying to open
> a normal symlink with O_NOFOLLOW and without O_PATH results in
> -ELOOP.)

It's not only that, it also supports sockets and pipes that you can access
via /proc/pid/fd and not via a real symlink which would try to open eg
"pipe:[23456]" instead of the real file. So you can't get rid of it
without breaking existing apps (starting with your shell for which
/dev/stdin is a link to /proc/self/fd/0 for example).

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/