Re: [PATCH 2/3] x86: don't use echo -e needlessly

[H. Peter Anvin]

Can we drop the /bin/?

Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
>-e is not needed to output strings without escape sequences.
>
>Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
>Cc: x86@xxxxxxxxxx
>Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
>---
> arch/x86/Makefile |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 07639c6..7386e8a 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -95,7 +95,7 @@ endif
> 
> ifdef CONFIG_X86_X32
> 	x32_ld_ok := $(call try-run,\
>-			/bin/echo -e '1: .quad 1b' | \
>+			/bin/echo '1: .quad 1b' | \
> 			$(CC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" - && \
> 			$(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMPO" && \
> 			$(LD) -m elf32_x86_64 "$$TMPO" -o "$$TMP",y,n)

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/