Re: [PATCH v1 3/4] spi/xilinx: Simplify irq allocation

[Mark Brown]

On Fri, Jul 12, 2013 at 04:00:24PM +0200, Michal Simek wrote:

> Just a follow up on this.

Sorry, this one fell through the cracks - apologies for the delay.

> Which function free private structures registered by spi_alloc_master function?
> Is it in spi_master_put()?

Yes, or spi_master_unregister() after it's been registered.

> The reason why I am asking is where clk_xx functions should be added.
> I see them between these two functions in sifr for example.

> And also I see in drivers in error probe path that drivers are calling kfree(master)
> but they are not doing in remove part (like spi-davinci.c).

> I just want to clear this in our zynq drivers before we send them out.

I'd not be surprised if there were errors in the error handling paths,
it's (hopefully!) not the best tested code out there.

Attachment: signature.asc
Description: Digital signature