Re: [PATCH] documentation/devicetree: Move DT bindigns from gpio towatchdog

[Johannes Thumshirn]

On Wed, Aug 21, 2013 at 11:34:00AM -0600, Stephen Warren wrote:
> On 08/21/2013 06:42 AM, Johannes Thumshirn wrote:
> > I accidently put the devicetree bindings for the MEN A21 watchdog driver in
> > Documentation/devicetree/bindings/gpio instead of
> > Documentation/devicetree/bindings/watchdog, this patch addresses this error.
>
> The rename sounds fine, so that part,
> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
>
> However, the binding itself doesn't look right; it appears to have a
> single "gpios" property rather than using separate named xxx-gpios
> properties for different things...

Ok, so I'll need something like the following?

watchdog {
	compatible ="men,a021-wdt";
	enable-gpios = <&gpio3 9 1>; /* WD_EN */
	fast-gpios = <&gpio3 10 1>;  /* WD_FAST */
	trig-gpios = <&gpio3 11 1>;  /* WD_TRIG */
	rst0-gpio = <&gpio3 6 1>;    /* RST_CAUSE[0] */
	rst1-gpio = <&gpio3 7 1>;    /* RST_CAUSE[1] */
	rst2-gpio = <&gpio3 8 1>;    /* RST_CAUSE[2] */
};

Or is there something like of_get_named_gpios(...) so I can put all 3 rst-gpios
into one property? A quick grep only revealed of_get_named_gpio(...).

Thanks,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/