Re: [PATCH 4/4] mfd: as3722: introduce regmap support

From: Mark Brown
Date: Wed Aug 21 2013 - 14:29:22 EST


On Tue, Aug 20, 2013 at 01:08:00PM +0100, Lee Jones wrote:
> On Tue, 20 Aug 2013, Florian Lobmaier wrote:

> > Signed-off-by: Florian Lobmaier <florian.lobmaier@xxxxxxx>
> > ---
> > drivers/mfd/as3722-regmap.c | 417 +++++++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 417 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/mfd/as3722-regmap.c

> I'll leave the review of this file to Mark, but it should be added
> either when you start calling the functions, or at least before they
> are used, or else the preceding commits won't build. This would cause
> someone a major headache if their bisect landed in the middle of your
> patches.

Mark wasn't CCed and only happened to notice this on the list... might
be worth checking!

Attachment: signature.asc
Description: Digital signature