Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

[Joe Perches]

On Tue, 2013-08-20 at 22:46 +0200, Francois Romieu wrote:
> liujunliang_ljl <liujunliang_ljl@xxxxxxx> :

> > +	if (i >= SR_SHARE_TIMEOUT) {
> > +		netdev_err(dev->net, "%s read timed out!", phy ? "phy" : "eeprom");

netdev_<level>, like almost all other printk
messages needs a terminating "\n" newline to
avoid any possible message interleaving by other
printks.

> > +	if (!is_valid_ether_addr(addr->sa_data)) {
> > +		dev_err(&net->dev, "not setting invalid mac address %pM\n",
> > +								addr->sa_data);
> 
> 		dev_err(&net->dev, "not setting invalid mac address %pM\n",
> 			addr->sa_data);

prefer netdev_<level> to dev_<level> where possible.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/