Re: [PATCH] via-ircc: don't return zero if via_ircc_open() failed

From: David Miller
Date: Tue Aug 20 2013 - 16:27:54 EST


From: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
Date: Fri, 16 Aug 2013 23:48:14 +0300

> If via_ircc_open() fails, data structures of the driver left uninitialized,
> but probe (via_init_one()) returns zero. That can lead to null pointer dereference
> in via_remove_one(), since it does not check drvdata for NULL.
>
> The patch implements proper error code propagation.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/