Re: [PATCH V3] regulator: palmas: add support for external controlof rails

[Mark Brown]

On Tue, Aug 20, 2013 at 06:44:15PM +0530, Laxman Dewangan wrote:

> +			econtrol = PALMAS_EXT_CONTROL_NSLEEP;
> +			if (!ret) {
> +				if (prop == 1)
> +					econtrol = PALMAS_EXT_CONTROL_ENABLE1;
> +				else if (prop == 2)
> +					econtrol = PALMAS_EXT_CONTROL_ENABLE2;
> +				else if (prop == 3)
> +					econtrol = PALMAS_EXT_CONTROL_NSLEEP;

Since Stephen identified an issue as well...  this looks like a switch
statement.   Otherwise this looks fine.

Attachment: signature.asc
Description: Digital signature