Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

From: Eric W. Biederman
Date: Tue Aug 20 2013 - 06:14:11 EST


Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@xxxxxxxxxxx> writes:

> Hi Ingo,
>
> Thank you for fixing typos!
> OK, I'll fix them and rename to ioapic_zap_locks().
>
> Thank you again!


The better fix for this would be to remove the disable_IO_APIC call from
crash_kexec.

I know last time it was investigated the kernel was very close to
working without needing that, and the code will be much more robust in
the long term if we can avoid disabling them in the crashing kernel.

Yoshihiro is there any chance you can look into removing the
disable_IO_APIC entirely?

The apic disablement and the disable_IO_APIC exists entirely due to
limitations in the kernel boot path.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/