Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USBID detection

[George Cherian]

Hi Stephen,

Thanks for your review.

On 8/20/2013 1:01 AM, Stephen Warren wrote:

> On 08/16/2013 04:13 AM, George Cherian wrote:
> > Adding extcon driver for USB ID detection to dynamically
> > configure USB Host/Peripheral mode.
> > diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt
> > +EXTCON FOR DRA7xx
> > +
> > +Required Properties:
> Please at lest explain what a DRA7xxx is, and the purpose of the HW
> module this binding describes.

DRA7xx is the SoC name and the USB VID  detection is implemented via gpio's
Basically it does only ID detection via GPIO and there is no VBUS 
detection in h/w.
> > + - compatible : Should be "ti,dra7xx-usb"
> If this is a USB VID detector rather than a full USB host controller,
> then "usb" in the binding is a bit over-reaching. Perhaps "-usb-vid" or
> "-usb-vid-detector" would be more accurate.

This will be renamed to dra7xx-extcon.
> > + - gpios : phandle to ID pin and interrupt gpio.
> This isn't just a phandle; it's phandle+args, or a GPIO specifier. Some
> reference should be made to ../gpio/gpio.txt for the format.

okay
> Why does the interrupt line need to be included in a list of GPIOs?

ID pins are connected to pcf8575, and the pcf8575's interrupt line is 
inturn connected to
gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin change.
> If the DRA7xxx is a VID detector, why does it even need/have any GPIOs
> associated with it; surely it has a dedicated VID input pin. Can you
> provide more details re: how the HW is structured.
>
> > +Optional Properties:
> > +  - interrupt-parent : interrupt controller phandle
> > +  - interrupts : interrupt number
> > +
> > +
> It's typical insert the following between those two blank lines:
>
> Example:
>
> ... or delete one of the blank lines.
>
> > +dra7x_extcon1 {
> > +		compatible = "ti,dra7xx-usb";
> > +		gpios = <&pcf_usb 1 0>,
> > +			<&gpio6 11 2>;
> > +		interrupt-parent = <&gpio6>;
> > +		interrupts = <11>;
> > +	};
> > +
> No need for that trailing blank line.

okay
>


--
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/