Re: [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places

From: Toshi Kani
Date: Mon Aug 19 2013 - 10:55:18 EST


On Sat, 2013-08-17 at 16:15 -0700, Greg KH wrote:
> On Sat, Aug 17, 2013 at 01:46:57PM -0600, Toshi Kani wrote:
> > lock_device_hotplug() serializes CPU & Memory online/offline and hotplug
> > operations. However, this lock is not held in the debug interfaces below
> > that initiate CPU online/offline operations.
> >
> > - _debug_hotplug_cpu(), cpu0 hotplug test interface enabled by
> > CONFIG_DEBUG_HOTPLUG_CPU0.
> > - cpu_probe_store() and cpu_release_store(), cpu hotplug test interface
> > enabled by CONFIG_ARCH_CPU_PROBE_RELEASE.
> >
> > This patch changes the above interfaces to hold lock_device_hotplug().
> >
> > Signed-off-by: Toshi Kani <toshi.kani@xxxxxx>
> > ---
> > arch/x86/kernel/topology.c | 2 ++
> > drivers/base/cpu.c | 16 ++++++++++++++--
> > 2 files changed, 16 insertions(+), 2 deletions(-)
>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Thanks Greg!
-Toshi



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/