Re: [PATCH 4/6] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource
From: Svenning Sørensen
Date: Mon Aug 19 2013 - 07:59:41 EST
On 19-08-2013 13:35, Julia Lawall wrote:
reg_base = devm_ioremap_resource(dev, r);
if (!musb->ctrl_base)
return -EINVAL;
Not really related to Julia's patch, apart from making it more obvious that
there's a bug here.
I believe it is reg_base that needs to be checked, right?
Indeed, it is all backwards. I could extend the patch, if you want.
I'll let Felipe decide on that, but I can't imagine any objections.
IS_ERR() is the proper test, of course :)
Svenning
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/