Re: [PATCH v2] dmaengine: make dmatest less noisy

[Dan Williams]

On Mon, Aug 19, 2013 at 1:37 AM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote:
>> Commit 95019c8c5 "dmatest: gather test results in the linked list"
>> started to warning whenever we add results to a test thread.
>> A warning for something completely normal? This is just cluttering
>> my terminal. Move to debug prints.
>>
>> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
>> --- a/drivers/dma/dmatest.c
>> +++ b/drivers/dma/dmatest.c
>
>> @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
>>       list_add_tail(&tr->node, &r->results);
>>       mutex_unlock(&info->results_lock);
>>
>> -     pr_warn("%s\n", thread_result_get(r->name, tr));
>> +     pr_debug("%s\n", thread_result_get(r->name, tr));
>
> This is the idea behind original DMATEST module logic.
> As far as I understand we would like to have them as warnings in case
> when driver is compiled in and tests are run from the beginning.
>
> Though, I sent a correction patch that moves "No error" messages to
> debug level which, I think, makes sense. I don't know why Dan still keep
> silent on my last message in the discussion [1].
>

Applying them now, and yes I agree with your patch to take this back
to the original implementation of not squawking on success.

> [1] http://www.spinics.net/lists/kernel/msg1581822.html
>
>
> --
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Intel Finland Oy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/