Re: [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native

From: Ingo Molnar
Date: Mon Aug 19 2013 - 03:11:37 EST



* Youquan Song <youquan.song@xxxxxxxxxxxxxxx> wrote:

> > Firstly, please use the customary (multi-line) comment
> > style:
> >
> > /*
> > * Comment .....
> > * ...... goes here.
> > */
> >
> > specified in Documentation/CodingStyle.
> >
> > Secondly, please send a patch against a vanilla (e.g.
> > v3.11-rc5) kernel, as I've already zapped your previous
> > patch from tip:x86/apic per your request.
> Hi Ingo,
>
> latest vanilla has no includes the patch yet, so I think it
> will be fine by only dropping it from tip tree.

I know that it's not included yet - because I have not sent
it to Linus.

My suggestion was to document the circumstances here via a
single patch, i.e. not a patch + revert-and-add-comments
patch, but via a simple add-comments patch. Agreed?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/