Re: [PATCH tip/core/rcu 3/5] rcu: Sort rcutorture module parameters

From: Paul E. McKenney
Date: Mon Aug 19 2013 - 00:04:03 EST


On Sat, Aug 17, 2013 at 07:57:40PM -0700, Josh Triplett wrote:
> On Sat, Aug 17, 2013 at 07:25:15PM -0700, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> >
> > There are getting to be too many module parameters to permit the current
> > semi-random order, so this patch orders them.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
>
> As long as you're reordering them anyway, how about grouping each of the
> variables together with the corresponding module parameter macros, and
> then dropping the comments that duplicate the module parameter
> documentation?
>
> With that change:
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Good point, done!

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/