Re: [PATCH tip/core/rcu 02/11] rcu: Expedite during suspend andresume only on smallish systems

From: Josh Triplett
Date: Sat Aug 17 2013 - 23:18:47 EST


On Sat, Aug 17, 2013 at 06:37:47PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
>
> Expedited grace periods are of dubious benefit on very large systems,
> so this commit restricts their automated use during suspend and resume
> to systems of 256 or fewer CPUs.
>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

This seems odd. If expedited grace periods don't help on large systems,
shouldn't you just compile them out entirely and ignore rcu_expedited,
rather than just in this one special case?

In any case, if this patch still makes sense, please squash it into the
previous one.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/