Re: Large pastes into readline enabled programs causes breakage fromv2.6.31 onwards

From: Margarita Manterola
Date: Sat Aug 17 2013 - 19:04:05 EST


Hi,

On Sat, Aug 17, 2013 at 5:28 PM, Pavel Machek <pavel@xxxxxx> wrote:

>> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
>> index 4bf0fc0..2ba7f4e 100644
>> --- a/drivers/tty/n_tty.c
>> +++ b/drivers/tty/n_tty.c
>> @@ -149,7 +149,8 @@ static int set_room(struct tty_struct *tty)
>> * characters will be beeped.
>> */
>> if (left <= 0)
>> - left = ldata->icanon && !ldata->canon_data;
>> + if (waitqueue_active(&tty->read_wait))
>> + left = ldata->icanon && !ldata->canon_data;
>> old_left = tty->receive_room;
>> tty->receive_room = left;

> Was this applied? You may want to cc rjw... it is a regression, it is
> not pretty, and it is something I blieve I hit but thought it was some
> kind of "X weirdness".

There were no replies to the previous mail asking for comments, and as
far as I can see this has not been applied. I don't know who rjw is,
could you be a bit more explicit, please?

--
Besos,
Marga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/