Re: [PATCH] print_worker_info: Handle pointer with more care

From: Richard Weinberger
Date: Fri Aug 16 2013 - 13:21:00 EST


Am 16.08.2013 18:53, schrieb Richard Weinberger:
>> Yeah, and that should be fine. &pwq->wq would be just an offset of wq
>
> Yep. Now my brain also parsed the C notation correctly.
> Sorry for the completely wrong patch.
>
>> from NULL which is an invalid pointer but probe_kernel_read() should
>> be able to handle that and probably just return 0 or -1 (all bits
>> set). I *think* what's necessary is making probe_kernel_read() use
>> mincore() to fine out whether the requested address is mapped (it
>> should return -EFAULT if not) and try to dereference the address iff
>> it's mapped.
>
> UML needs a custom probe_kernel_read()? Fine. :)

With my own probe_kernel_read() that uses mincore()
it works fine so far. :-)

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/