Re: [PATCH 1/5] drivers/gpio/gpio-omap.c: convert comma to semicolon

From: Linus Walleij
Date: Fri Aug 16 2013 - 11:13:39 EST


On Mon, Aug 12, 2013 at 6:15 PM, Kevin Hilman <khilman@xxxxxxxxxx> wrote:
> Joe Perches <joe@xxxxxxxxxxx> writes:
>
>> On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
>>> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>>> Replace a comma between expression statements by a semicolon.
>> []
>>> I can't tell if the assignment to ct->regs.mask is really intended to be
>>> under the if. The proposed patch preserves the current semantics, but not
>>> the current indentation.
>>
>> I'd suspect more that the indentation is correct
>> and the comma use incorrect.
>>
>> It also looks more like a copy/paste error from
>> commit f8b46b583 when the code was restructured
>> a bit.
>>
>> Kevin?
>
> Yes, looks like a copy/paste error. The comma should simply be replaced
> by a semi-colon.

So can I have a patch for this? Pretty please...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/