Re: [PATCH] gpio: adnp: Fix segfault if request_threaded_irq fails

From: Linus Walleij
Date: Fri Aug 16 2013 - 10:54:00 EST


On Wed, Aug 7, 2013 at 5:23 PM, Lars Poeschel <larsi@xxxxxxxxxxxxxxxxx> wrote:

> From: Lars Poeschel <poeschel@xxxxxxxxxxx>
>
> In case request_threaded_irq inside adnp_irq_setup fails, the driver
> segfaults. This is because irq_domain_remove is called twice with
> the same pointer. First time in adnp_irq_setup and then a second time
> after leaving adnp_irq_setup in the error path of adnp_i2c_probe
> inside adnp_teardown.
> This fixes this by removing the call to irq_domain_remove from
> adnp_irq_setup.
>
> Signed-off-by: Lars Poeschel <poeschel@xxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/