Re: [RFC PATCH] Fix aio performance regression for database causedby THP

[Khalid Aziz]

On 08/16/2013 03:04 AM, Kirill A. Shutemov wrote:
> On Thu, Aug 15, 2013 at 12:13:09PM -0600, Khalid Aziz wrote:
> > -	if (likely(page != page_head && get_page_unless_zero(page_head))) {
> > +	/*
> > +	 * If this is a hugetlbfs page, it can not be split under
> > +	 * us. Simply increment refcount for head page
> > +	 */
> > +	if (PageHuge(page)) {
> > +		page_head = compound_head(page);
> > +		atomic_inc(&page_head->_count);
> > +		got = true;
>
> Why not just return here and don't increase indentantion level for rest of
> the function?

Good point.

Andrew, I can rework the patch if you would like.

Thanks,
Khalid
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/