Re: [PATCH] regulator: core: Use the power efficient workqueue fordelayed powerdown

From: Viresh Kumar
Date: Thu Jul 18 2013 - 06:56:27 EST


On 18 July 2013 16:23, Mark Brown <broonie@xxxxxxxxxx> wrote:
> From: Mark Brown <broonie@xxxxxxxxxx>
>
> There is no need to use a normal per-CPU workqueue for delayed power downs
> as they're not timing or performance critical and waking up a core for them
> would defeat some of the point.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
> drivers/regulator/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index b6efead..6ef476f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1891,8 +1891,9 @@ int regulator_disable_deferred(struct regulator *regulator, int ms)
> rdev->deferred_disables++;
> mutex_unlock(&rdev->mutex);
>
> - ret = schedule_delayed_work(&rdev->disable_work,
> - msecs_to_jiffies(ms));
> + ret = queue_delayed_work(system_power_efficient_wq,
> + &rdev->disable_work,
> + msecs_to_jiffies(ms));
> if (ret < 0)
> return ret;
> else

Cool!! People have started to use this interface now :)

Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/