Re: [PATCH 2/4] mfd: dbx500-prcmu: Correctly reorder PRCMU clock identifiers

From: Linus Walleij
Date: Fri Jun 07 2013 - 09:13:24 EST


On Thu, Jun 6, 2013 at 1:21 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> ... as stipulated by the Hardware Specification document.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

I think you need Ulf (as ux500 clock author) and Loic (as PRCMU
developer) to have a look at this.

> -enum prcmu_clock {
> - PRCMU_SGACLK,
(...)
> +#define ARMCLK 0
> +#define PRCMU_ACLK 1
(...)

It seems the enum and the defines want to do two different things?

The first is a kernel-internal representation of the clocks, whereas
the latter is a HW-centric representation for a certain PRCMU
variant (I guess?)

Does one actually exclude the other?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/