Re: [ 061/184] PCI/PM: Clean up PME state when removing a device

[Willy Tarreau]

On Fri, Jun 07, 2013 at 05:23:56AM +0100, Ben Hutchings wrote:
> On Tue, 2013-06-04 at 19:22 +0200, Willy Tarreau wrote:
> > 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: "Rafael J. Wysocki" <rjw@xxxxxxx>
> > 
> > commit 249bfb83cf8ba658955f0245ac3981d941f746ee upstream.
> > 
> > Devices are added to pci_pme_list when drivers use pci_enable_wake()
> > or pci_wake_from_d3(), but they aren't removed from the list unless
> > the driver explicitly disables wakeup.  Many drivers never disable
> > wakeup, so their devices remain on the list even after they are
> > removed, e.g., via hotplug.  A subsequent PME poll will oops when
> > it tries to touch the device.
> > 
> > This patch disables PME# on a device before removing it, which removes
> > the device from pci_pme_list.  This is safe even if the device never
> > had PME# enabled.
> 
> There's no such list in 2.6.32, so I don't think this is needed.

Dropped, thanks !

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/