Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

From: Dan Carpenter
Date: Thu Jun 06 2013 - 17:22:31 EST


On Thu, Jun 06, 2013 at 06:10:47PM +0200, Johannes Schilling wrote:
> @@ -321,7 +320,7 @@ int ENE_Write_Data(struct us_data *us, void *buf, unsigned int length)
> /*
> * usb_stor_print_cmd():
> */
> -void usb_stor_print_cmd(struct scsi_cmnd *srb)
> +void usb_stor_print_cmd(struct us_data *us,struct scsi_cmnd *srb)
^^
Missing space. Run checkpatch.pl over your patch to find these.
This can be fixed in a later patch I think.

> {
> PBYTE Cdb = srb->cmnd;
> DWORD cmd = Cdb[0];

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/