Re: [PATCH] of: Export of_irq_count for using in modules

From: Grant Likely
Date: Thu Jun 06 2013 - 07:56:15 EST


On Thu, Jun 6, 2013 at 9:39 AM, Michal Simek <monstr@xxxxxxxxx> wrote:
> On 06/06/2013 10:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 18:45 Fri 31 May , Michal Simek wrote:
>>> ok. good to know. Btw: Let's return to my origin point why not to
>>> export of_irq_count for modules?
>>> Or opposite question if platform_get_resource is correct way
>>> why to export of_irq_to_resource for modules?
>>
>> for old ppc drivers that are not converted yet to pdev
>>
>> if you can do so just use pdev resource I should have fix the pb or irq_domain
>> hopefully for 3.11
>
> ok. It means it is currently deprecated.
> I just wanted to be sure that I understand it correctly.

It's deprecated for platform_devices, but should still be used for
other bus types that don't provide the device driver with a list of
irqs. For platform devices it is best to use the platform_bus irq
table since that is portable regardless of how the device is
instantiated.

As for not exporting of_irq_count(), I don't have a problem with it,
but only if there is a user. It sounds like with the rework you
discussed with Jean-Christophe that it is no longer the case.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/