Re: [PATCH] ARM: samsung: avoid racy early printk at bootup

From: Doug Anderson
Date: Wed Jun 05 2013 - 16:57:02 EST


Olof,

On Tue, Jun 4, 2013 at 8:15 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
> This seems to be caused by not calling iotable_ini() in exynos_init_io()
> when a device tree is passed into the kernel, thus not setting up the
> mapping for the UART in that case.
>
> I think the solution is instead to map the uart earlier. The window of
> exposure is still there, but much smaller (and similar to how it always
> has been).
>
> In current upstream, if there is no map_io mach_desc entry at all,
> debug_ll_io_init() will be called on all platforms. Seems appropriate
> to call that explicitly before of_scan_flat_dt() in exynos_init_io()
> in this case.

Oh. Ummm, right. Yes, debug_ll_io_init() is exactly what's needed
here instead of all the complexity of what I proposed. New patch
coming shortly. Thanks! :)

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/