Re: pull request: wireless 2013-06-03

[John W. Linville]

On Tue, Jun 04, 2013 at 01:18:13PM -0700, David Miller wrote:
> From: "John W. Linville" <linville@xxxxxxxxxxxxx>
> Date: Mon, 3 Jun 2013 14:48:17 -0400
> 
> > Please let me know if there are problems!
> 
> Sorry, the broadcom brcmfmac changes need to go.
> 
> Some of those commits are cleanups, and some of them have the worst
> commit log messages ever, the last one for example:
> 
> 0017-brcmsmac-fix-regression-observed-in-3.10-rc1.patch
> 
> has no explanation whatsoever of what the actual problem or regression
> is, what aspect of the logic in that function is causing the problem,
> and no explanation why making this function always return 'false' is a
> reasonable fix.
> 
> That entire series is of very low quality, and even if it was in good
> shape, at least half the changes are not appropriate at all this late
> in the -rc series.

OK, sorry Dave -- I knew better...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/