Re: [RFC PATCH v0 1/2] dma: move dw_dmac driver to an own directory

[Andy Shevchenko]

On Mon, 2013-06-03 at 10:25 +0530, Viresh Kumar wrote: 
> On 31 May 2013 21:20, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> > +obj-$(CONFIG_DW_DMAC) += dw/
> 
> > +++ b/drivers/dma/dw/Makefile
> > +obj-$(CONFIG_DW_DMAC) += dw_dmac.o
> 
> The lower one should be obj-y += dw_dmac.o as this will always
> be true.

Imagine the case when we choose platform driver to be compiled as a
module. It means both variables set to m.

During compilation we will have core part compiled-in, and platform part
as a module.

I don't think this is what we want. 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/