Re: [PATCH] eCryptfs: Cocci spatch "memdup.spatch"

From: Tyler Hicks
Date: Sun Jun 02 2013 - 22:48:05 EST


On 2013-06-01 11:39:36, Thomas Meyer wrote:
>
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> ---

Thanks Thomas - I've pushed this to my next branch.

Tyler

>
> diff -u -p a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -247,14 +247,13 @@ int ecryptfs_process_response(struct ecr
> goto unlock;
> }
> msg_size = (sizeof(*msg) + msg->data_len);
> - msg_ctx->msg = kmalloc(msg_size, GFP_KERNEL);
> + msg_ctx->msg = kmemdup(msg, msg_size, GFP_KERNEL);
> if (!msg_ctx->msg) {
> rc = -ENOMEM;
> printk(KERN_ERR "%s: Failed to allocate [%zd] bytes of "
> "GFP_KERNEL memory\n", __func__, msg_size);
> goto unlock;
> }
> - memcpy(msg_ctx->msg, msg, msg_size);
> msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_DONE;
> wake_up_process(msg_ctx->task);
> rc = 0;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: Digital signature