Re: [PATCH] power: replace strict_strtoul() with kstrtoul()

From: Andy Shevchenko
Date: Sun Jun 02 2013 - 06:36:31 EST


On Sat, Jun 1, 2013 at 10:27 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.

> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -2467,7 +2467,7 @@ static ssize_t charge_full_store(struct ab8500_fg *di, const char *buf,
> unsigned long charge_full;
> ssize_t ret = -EINVAL;

Redundant assignment.

> --- a/drivers/power/pcf50633-charger.c
> +++ b/drivers/power/pcf50633-charger.c
> @@ -191,7 +191,7 @@ static ssize_t set_usblim(struct device *dev,
> unsigned long ma;
> int ret;
>
> - ret = strict_strtoul(buf, 10, &ma);
> + ret = kstrtoul(buf, 10, &ma);
> if (ret)
> return -EINVAL;

return ret;

> @@ -228,7 +228,7 @@ static ssize_t set_chglim(struct device *dev,
> if (!mbc->pcf->pdata->charger_reference_current_ma)
> return -ENODEV;
>
> - ret = strict_strtoul(buf, 10, &ma);
> + ret = kstrtoul(buf, 10, &ma);
> if (ret)
> return -EINVAL;

Ditto.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/