Re: [PATCH 09/11] gpio: davinci: DT changes for driver
From: Linus Walleij
Date: Thu May 30 2013 - 14:25:36 EST
On Wed, May 22, 2013 at 9:10 AM, Philip Avinash <avinashphilip@xxxxxx> wrote:
(...)
> +- interrupts: The Starting IRQ number for GPIO
> +- intc_irq_num: The number of IRQs supported by the Interrupt Controller
(...)
No this is not how you pass a number of IRQs in the device tree.
"interrupts" is an array. Pass every interrupt here for a full
resolution of the IRQs.
Further this looks fishy:
+ interrupts = <42>;
Usually you pass flags with the IRQs, I would rather have expected
an array like this:
interrupts = < 90 0x4 96 0x4 14 0x4 15 0x4 79 0x4>;
0x4 is IRQ_TYPE_LEVEL_HIGH, you can use the dts
#include <dt-bindings/interrupt-controller/irq.h> and
define that symbolically.
Doesn't the DaVinci IRQ controller support *any* IRQ flags?
Since the driver code is not reading out the interrupts but
(I guess?) falling back to platform data IRQ assignment,
this seems wrong.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/