Re: [PATCH v2] ata: increase retry count but shorten duration forCalxeda controller

[Sergei Shtylyov]

Hello.

On 30-05-2013 18:26, Timur Tabi wrote:

> > -	const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
> > +	const unsigned long timing[] = { 5, 100, 500};

> You'll save space and time if you also make this array "static",
> otherwise the compiler will build the array every time this function is
> called.

   No, *const* specifier is enough to not build this array every time. 
It will be put into the .const section.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/