Re: possible_cpus broken in linux-next

From: Toshi Kani
Date: Wed May 29 2013 - 14:50:26 EST


On Wed, 2013-05-29 at 12:35 -0600, Toshi Kani wrote:
> On Wed, 2013-05-29 at 10:10 -0700, Dave Hansen wrote:

:

> Thanks for the report. The following patch fixes the problem.
> -Toshi
>
> ====
> From: Toshi Kani <toshi.kani@xxxxxx>
> Subject: [PATCH] ACPI: Fix sysfs cpu/online of offlined cpus

Typo. The subject needs to be:

Subject: [PATCH] cpu: Fix sysfs cpu/online of offlined cpus

-Toshi

> As reported by Dave Hansen, sysfs cpu/online shows 1 for
> offlined cpus at boot.
> https://lkml.org/lkml/2013/5/29/403
>
> Fix this problem by initializing dev.offline with cpu_online()
> when registering a cpu.
>
> Reported-by: Dave Hansen <dave.hansen@xxxxxxxxx>
> Signed-off-by: Toshi Kani <toshi.kani@xxxxxx>
> ---
> drivers/base/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 130ba0b..b9f0eec 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -281,6 +281,7 @@ int __cpuinit register_cpu(struct cpu *cpu, int num)
> cpu->dev.bus = &cpu_subsys;
> cpu->dev.release = cpu_device_release;
> cpu->dev.offline_disabled = !cpu->hotpluggable;
> + cpu->dev.offline = !cpu_online(num);
> #ifdef CONFIG_ARCH_HAS_CPU_AUTOPROBE
> cpu->dev.bus->uevent = arch_cpu_uevent;
> #endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/