Re: [PATCH 2/3] ARM: u8540: Add Pinctrl Device Tree settings foruart0, uart2
From: Linus Walleij
Date: Wed May 29 2013 - 12:48:37 EST
On Tue, May 28, 2013 at 12:09 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Mon, 27 May 2013, Gabriel Fernandez wrote:
>> From: Gabriel Fernandez <gabriel.fernandez@xxxxxx>
>>
>> This patch adds pinctrl device tree settings for uart0 and uart2
>> for ccu8540 board.
>>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxx>
>> ---
>> arch/arm/boot/dts/ccu8540-pinctrl.dtsi | 77 ++++++++++++++++++++++++
>> arch/arm/boot/dts/ccu8540.dts | 7 +++
>> arch/arm/boot/dts/dbx5x0.dtsi | 2 +-
>> arch/arm/boot/dts/ste-nomadik-pinctrl.dtsi | 95 ++++++++++++++++++++++++++++++
>
> This is starting to get a bit confusing. How intrusive would it be to
> place the ccu8540-pinctrl information inside ccu8540.dts instead of
> breaking it out into different files and convoluting the issue?
>
> Also, please correct me if I'm wrong, but isn't what we call the
> Nomadik Pinctrl/GPIO really the same as DBX500 Pinctrl/GPIO? I wonder
> if this would be a better naming convention?
>
> Linus, what do you think?
I think the definitions can live in their own file like this since it
saves a lot of
lines... And the use of <dt-bindings/*> is really nice.
> Nodes look pretty good, except shouldn't 'ste' really be 'stericsson'?
I started to use ste-* on the Nomadik and U300 stuff to avoid all too
long filenames.
I would actually like to rename all the ux500-related files ste-*
so they get grouped together in the filelist, but I've heard that there
was a plan to create per-vendor subdirs in arch/arm/boot/dts
so maybe I should go for that instead?
[Gabriel]
> i missed
> pinctrl {
> compatible = "stericsson,db8540-pinctrl";
Are you sending a v2?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/