Re: [PATCH v3 part1 1/4] sg_io: pass request_queue toblk_verify_command

From: James Bottomley
Date: Fri May 24 2013 - 03:36:18 EST


On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote:
> Adjust the blk_verify_command function to let it look at per-queue
> data. This will be done in the next patch.

This is not a bug fix. This is an enabler for your complex and to my
mind dubious rework of the SG_IO command filter. I'm running out of
ways to say please don't mix bug fixes with features, because this
redesignating of the original patch set as part 1 and parts 2,3 doesn't
satisfy the requirement.

Does anyone in the real world actually care about this bug? because if
not perhaps we can just remove the confusion and consider this as a
feature set. If there's someone who actually cares, please lets just do
the bug fix first and argue about the feature later.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/